Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-design the keyboard module #238

Open
DvirB10 opened this issue May 17, 2021 · 0 comments
Open

Re-design the keyboard module #238

DvirB10 opened this issue May 17, 2021 · 0 comments

Comments

@DvirB10
Copy link
Contributor

DvirB10 commented May 17, 2021

Hi! After adding the support of ctrl-L keyboard shortcut, I've noticed the keyboard strokes are managed in a one big if...else, and that some of the keystrokes being handled are the same for both magictype and regulartype. ( Like ctrl-L :) )

I think it will be better to manage the keystrokes for both magictype and regulartype together, at least some of them to avoid code duplication. Also, both of them are getting the same parameters but text, which also cause a little bit of code duplication.

Any suggestions or disagreements will be happily received.
I hope it's ok 😟 It's my first time trying to help an open-source project :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant