Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude files #12

Closed
danielfleischer opened this issue Jun 10, 2023 · 4 comments
Closed

Exclude files #12

danielfleischer opened this issue Jun 10, 2023 · 4 comments

Comments

@danielfleischer
Copy link

Similar to #11, keyword :files can help exclude some elisp files; some packages have extra extensions (org-ql + helm support) which can be excluded. Is there a way to support that?

@slotThe
Copy link
Owner

slotThe commented Jun 11, 2023

Is there a way to support that?

I don't believe so. Fundamentally, we are still constrained to the API that package-vc.el supports, and—at least currently—it does not support excluding files. Perhaps this could be a feature request to Emacs instead? I don't think this would be particularly hard to implement (famous last words, I know, but still).

(Personally, I also think it's better for this to be implemented at the package level; split off orq-ql-helm.el into an extra package, instead of having to awkwardly ignore single elisp files)

@danielfleischer
Copy link
Author

(Personally, I also think it's better for this to be implemented at the package level; split off orq-ql-helm.el into an extra package, instead of having to awkwardly ignore single elisp files)

Exactly the usecase I had in mind!

I started a discussion on the mailing list. It appears there's an inherent technical and philosophical difference between ELPA packages and MELPA packages such that recipes can't be compatible and file-ignoring is not necessary when you follow ELPA packaging guideline. I could be wrong though. Either way, package-vc appears to not fill my needs right now. Maybe that'll change in the future.

@alphapapa
Copy link

(Personally, I also think it's better for this to be implemented at the package level; split off orq-ql-helm.el into an extra package, instead of having to awkwardly ignore single elisp files)

helm-org-ql is a separate package. Its source code file happens to live in the same repository as org-ql. For small, ancillary packages like helm-org-ql, it's often easier for the author to keep it together with the "parent" package.

ELPA packages and MELPA packages such that recipes can't be compatible and file-ignoring is not necessary when you follow ELPA packaging guideline.

It appears that at least 65 ELPA packages include :ignored-files in their recipes (see the elpa-packages file).

So it would seem that this is a reality that package-vc needs to handle.

@slotThe
Copy link
Owner

slotThe commented Oct 15, 2023

Implemented as of https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=68318dfd1652151f7d08f7682303499494a0c427

Thanks everyone for bringing this along!

@slotThe slotThe closed this as completed Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants