Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested beamer delegate not rebuild correctly upon deep-link #555

Closed
MarkRunWu opened this issue Aug 1, 2022 · 2 comments
Closed

Nested beamer delegate not rebuild correctly upon deep-link #555

MarkRunWu opened this issue Aug 1, 2022 · 2 comments

Comments

@MarkRunWu
Copy link
Contributor

MarkRunWu commented Aug 1, 2022

For a flutter app with nested delegates i observe that the nested delegate doesn't rebuild itself by deeplink to already opening app.

Short steps to reproduce on android:

  • have nested beamer delegates
  • simulate a deeplink action by the command adb -s shell am start -a android.intent.action.VIEW -c android.intent.category.BROWSABLE -d "<deeplink-path-to-second-beamer-delegate>"
  • once forward to app by the deeplink, you would see only the first screen in the first beamer delegate is rendered but the beaming history in second delegate now have new record but doesn't get rendered.

After i traced the code, i found the rebuild flag in following code is always false. Once update to respect the rebuild parameter, the second navigator get re-rendered and the screen is correctly shown.
https://github.com/slovnicki/beamer/blob/master/package/lib/src/beamer_delegate.dart#L1068

@slovnicki
Wander if there are any concern with the hard-code rebuild flag ?

@keisau
Copy link

keisau commented Aug 16, 2022

We are facing the same problem and thus really like to see the fix released soon (it doesn't seem to be in the latest 1.5.1 release)

Thanks!!

@slovnicki @MarkRunWu

@slovnicki
Copy link
Owner

Hey @keisau 👋
This valuable fix from @MarkRunWu is now live in v1.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants