Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i wanna help #1

Closed
rares45 opened this issue Nov 29, 2020 · 2 comments
Closed

i wanna help #1

rares45 opened this issue Nov 29, 2020 · 2 comments

Comments

@rares45
Copy link
Contributor

rares45 commented Nov 29, 2020

I know you are working alone right now. It's that intentional? Can I help? I could work on the design, user experience and fixing some bugs if you want. What's your opinion about Kotlin? And if I can help, what's the PR Workflow?

Edit: Do you really like that purple?
Edit 2: Can I translate it to Romanian?
Edit 3: How are you planning to implement the favourite function?

@slowscript
Copy link
Owner

Of course you can help. I'm not very good at design so if you could help with that I would appreciate it. However I'm currently working on some major changes and want to release a beta version by the end of next week, so it would be probably better if you wait for after that.

I don't know much about Kotlin, I plan to keep this project in Java. I also don't have any special PR workflow. Just open a PR (or a draft PR if you are working on something and want to let me/others know about it).

I chose that purple because it vaguely resembles the color on the icon of the original Warpinator. You can change that if you want.

I haven't gotten to making strings translatable yet. Most of them are still hardcoded.

The "favourite" function is on my todo list. I haven't thought about implementation details yet.

@rares45
Copy link
Contributor Author

rares45 commented Nov 29, 2020

I'm not very good at design so if you could help with that I would appreciate it.

Already done it.

so it would be probably better if you wait for after that.

Too late. I was bored today so I spent my time working on this. I think I'm gonna make a PR draft and fix the conflicts(if any) after you push your commits. I think Git should do it for me.

I don't know much about Kotlin, I plan to keep this project in Java.

I know both of them, that's why I asked. I have no problem with Java.

I haven't gotten to making strings translatable yet. Most of them are still hardcoded.

Fixed that already.

@rares45 rares45 closed this as completed Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants