Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][byob] Re-visit workflow structure #2077

Open
laurentsimon opened this issue Apr 28, 2023 · 2 comments
Open

[feature][byob] Re-visit workflow structure #2077

laurentsimon opened this issue Apr 28, 2023 · 2 comments
Labels
area:BYOB An issue with the BYOB framework type:feature New feature or request

Comments

@laurentsimon
Copy link
Collaborator

laurentsimon commented Apr 28, 2023

In the v1.0, we may leave

 workflow: {
          ref: rawTokenObj.github.ref,
          repository: rawTokenObj.github.repository,
          path: getWorkflowPath(rawTokenObj.github),
        },

blank, because:

  1. The interface to our builder has nothing to do with this workflow
  2. The trigger workflow is present in the env variables anyway, in case someone wants to know about it
@laurentsimon laurentsimon added type:feature New feature or request area:BYOB An issue with the BYOB framework labels Apr 28, 2023
@laurentsimon laurentsimon added this to the BYOB framework milestone Apr 28, 2023
@laurentsimon
Copy link
Collaborator Author

laurentsimon commented May 23, 2023

/cc @asraa relevant to the discussion in slsa-framework/slsa-verifier#610. Let's keep this usse for tracking the update to docker-based builder and the BYOB builders.

We tentatively agreed in the other issue to keep the workflow but move it under internalParameters for builders. Generators will need to keep the workflow in externalParameters. Probably we need a new bool input to the verify-token indicating if the call is for a generator or a builder.

@laurentsimon
Copy link
Collaborator Author

Given that there's already GITHUB_WORKFLOW_REF recorded in the internalParameters, I think we can drop the workflow entirely if it's a builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:BYOB An issue with the BYOB framework type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant