Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Update actions/setup-go and google-github-actions/auth to avoid Node.js 16 deprecation warnings #3623

Closed
chipzoller opened this issue May 13, 2024 · 5 comments
Labels
area:container Issue with the generic container generator type:feature New feature or request

Comments

@chipzoller
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As of v2.0.0 of the generator, these two actions as called by the container generator use Node.js 16 which is deprecated and upon every run show warnings.

Describe the solution you'd like
Update these actions to later versions which use Node.js 20.

Describe alternatives you've considered
Ignore the warnings.

Additional context
Lots of open issues in this repository, some look like they already cover these deprecation warnings. Feel free to close if this is a duplicate and these are already being tracked.

@chipzoller chipzoller added status:triage Issue that has not been triaged type:feature New feature or request labels May 13, 2024
@ianlewis
Copy link
Member

We did upgrade our own actions in #3245 but it seems these were missed.

@ianlewis ianlewis added area:container Issue with the generic container generator and removed status:triage Issue that has not been triaged labels May 14, 2024
@ianlewis
Copy link
Member

ianlewis commented May 14, 2024

#3619 should also fix softprops/action-gh-release but we still need to update google-github-actions/auth since we are still using v1.1.1 which uses node16.

https://github.com/google-github-actions/auth/blob/35b0e87d162680511bf346c299f71c9c5c379033/action.yml#L189

@ianlewis
Copy link
Member

Now that renovate is working again, this should get fixed by #3648

@ianlewis
Copy link
Member

#3648 was merged so this should be fixed in the next release.

@chipzoller
Copy link
Contributor Author

The community thanks you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:container Issue with the generic container generator type:feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants