Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Update generic builder type #627

Closed
laurentsimon opened this issue Jul 25, 2022 · 1 comment · Fixed by #628
Closed

[feature] Update generic builder type #627

laurentsimon opened this issue Jul 25, 2022 · 1 comment · Fixed by #628
Assignees
Labels
type:feature New feature or request

Comments

@laurentsimon
Copy link
Collaborator

The Go builder type has:

"buildType": "https://github.com/slsa-framework/slsa-github-generator/go@v1",

the generic generator ahs:

"buildType": "https://github.com/slsa-framework/slsa-github-generator@v1",

I'm not sure this is consistent. Should the latter be https://github.com/slsa-framework/slsa-github-generator/generic@v1?

Or maybe we should keep https://github.com/slsa-framework/slsa-github-generator@v1 for all of them, since the builder name is available anyway?

/cc @ianlewis

@laurentsimon laurentsimon added type:feature New feature or request status:triage Issue that has not been triaged labels Jul 25, 2022
@ianlewis ianlewis removed the status:triage Issue that has not been triaged label Jul 25, 2022
@ianlewis
Copy link
Member

Yeah, I think https://github.com/slsa-framework/slsa-github-generator/generic@v1 is more consistent since it fits into a https://github.com/slsa-framework/slsa-github-generator/<builder-name>@v1 pattern.

@ianlewis ianlewis added this to the GA for generic generator milestone Jul 25, 2022
@ianlewis ianlewis self-assigned this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants