Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Rename attestation.intoto.jsonl to provenance.intoto.jsonl #654

Closed
laurentsimon opened this issue Aug 1, 2022 · 3 comments · Fixed by #777
Closed

[feature] Rename attestation.intoto.jsonl to provenance.intoto.jsonl #654

laurentsimon opened this issue Aug 1, 2022 · 3 comments · Fixed by #777
Labels
area:generic Issue with the generic generator type:feature New feature or request

Comments

@laurentsimon
Copy link
Collaborator

laurentsimon commented Aug 1, 2022

Shall we rename the default provenance filename for the generic workflows?

Maybe slsa3-provenance.intoto.jsonl or simply provenance.intoto.jsonl?

@ianlewis wdut?

@laurentsimon laurentsimon added type:feature New feature or request status:triage Issue that has not been triaged labels Aug 1, 2022
@ianlewis
Copy link
Member

ianlewis commented Aug 1, 2022

The original intent was to indicate that it was the provenance was signed and included the signature, but maybe provenance makes more sense since I think most folks will be more familiar with that.

@ianlewis ianlewis added area:generic Issue with the generic generator and removed status:triage Issue that has not been triaged labels Aug 1, 2022
@ianlewis
Copy link
Member

BTW, the in-toto attestation doc states:

  • Bundles that concern a single artifact SHOULD name the bundle file <artifact filename>.intoto.jsonl.
  • Bundles that concern multiple artifacts SHOULD name the bundle file multiple.intoto.jsonl.

So maybe we should be adhering to this as the default file names.

@laurentsimon
Copy link
Collaborator Author

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:generic Issue with the generic generator type:feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants