Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add support for display_data in bar plot #3387

Closed
2 tasks done
fountaindive opened this issue Nov 16, 2023 · 0 comments · Fixed by #3386
Closed
2 tasks done

ENH: add support for display_data in bar plot #3387

fountaindive opened this issue Nov 16, 2023 · 0 comments · Fixed by #3386
Labels
enhancement Indicates new feature requests

Comments

@fountaindive
Copy link
Contributor

Problem Description

shap.plots.bar doesn't seem to use .display_data when plotting which is useful when categorical features have been encoded.

Alternative Solutions

I've added a PR here: #3386 that uses the same logic as the waterfall plot. The feature values will be taken from .display_data if it exists and then tries .data

Additional Context

No response

Feature request checklist

  • I have checked the issue tracker for duplicate issues.
  • I'd be interested in making a PR to implement this feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Add support for Explanation.display_data in bar plot fountaindive/shap
1 participant
@fountaindive