New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wheel build - Skip tests for cp37 and cp38-macosx_x86_64 #3015
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3015 +/- ##
==========================================
- Coverage 54.79% 54.78% -0.01%
==========================================
Files 90 90
Lines 12895 12895
==========================================
- Hits 7066 7065 -1
- Misses 5829 5830 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for the PR!
Just one request, please add a comment in the YAML file to explain the rationale behind the skipped tests, that the catboost wheel is not available. You could reference this PR number for more info.
FYI I edited the description to change "closes #3012" to "related: #3012", as I don't think this PR by itself will fully close that issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PrimozGodec I noticed one other change to address, please see the thread above.
I changed the PR to draft since I want to test what work and what doesn't will change it to ready later |
I would like to get the main changed merged in soon, so we can keep progressing towards a release. So, if the win32 build issue is not something that can be resolved quickly, I'd suggest removing that from the scope of this PR and raising a separate issue. |
95346aa
to
c8cdaa5
Compare
c8cdaa5
to
28f68e9
Compare
@@ -12,6 +12,7 @@ jobs: | |||
name: Build wheels on ${{ matrix.os }} | |||
runs-on: ${{ matrix.os }} | |||
strategy: | |||
fail-fast: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this for easier debugging. That one build does not finish because of another. E.g. the Windows build does not finish because of failing MacOS. The whole building will still fail at the end, and no upload will happen.
Good. I made a PR ready to merge and will continue with debugging in a separate PR after #3021 and #3020 are merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! I merged in master to update the branch, so will merge once the tests pass.
Overview
Description of the changes proposed in this pull request:
Fix tests in the wheel build
Checklist
CHANGELOG.md
(if changes will affect users)