Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Specify encoding of imdb dataset, to fix build on Windows #3031

Merged
merged 1 commit into from Jun 23, 2023

Conversation

connortann
Copy link
Collaborator

@connortann connortann commented Jun 23, 2023

Fixes #3030 , verified locally . Required to get build passing on Windows

@connortann connortann added the bug Indicates an unexpected problem or unintended behaviour label Jun 23, 2023
@connortann connortann added this to the 2023-06-fixes milestone Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #3031 (e676e88) into master (3c10327) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #3031   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          90      90           
  Lines       12913   12913           
======================================
  Misses      12913   12913           
Impacted Files Coverage Δ
shap/datasets.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@connortann connortann changed the title Specify encoding of imdb dataset FIX: Specify encoding of imdb dataset, to fix build on Windows Jun 23, 2023
Copy link
Collaborator

@thatlittleboy thatlittleboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sitting-cat-high-five

@connortann connortann merged commit 084fe3d into master Jun 23, 2023
13 checks passed
@connortann connortann deleted the fix/encodings branch June 23, 2023 16:44
@connortann connortann modified the milestones: 2023-06-fixes, 0.42.0 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Tests fail on Windows due to encoding error
2 participants