New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHORE: Use faster test translation scenario, cut CI time by ~5mins #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortann
changed the title
Use faster test translation scenario
CHORE: Use faster test translation scenario
Jun 26, 2023
Codecov Report
@@ Coverage Diff @@
## master #3046 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 90 90
Lines 12850 12850
======================================
Misses 12850 12850 馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more |
connortann
changed the title
CHORE: Use faster test translation scenario
CHORE: Use faster test translation scenario, faster tests by ~5min
Jun 27, 2023
connortann
changed the title
CHORE: Use faster test translation scenario, faster tests by ~5min
CHORE: Use faster test translation scenario
Jun 27, 2023
connortann
changed the title
CHORE: Use faster test translation scenario
CHORE: Use faster test translation scenario, cut CI time by ~5mins
Jun 27, 2023
thatlittleboy
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #3045
Overview
Changes the model used in the translation scenario to amuch smaller one that will run much faster:
https://huggingface.co/mesolitica/finetune-translation-t5-super-super-tiny-standard-bahasa-cased
Timings
The change seems to save ~5 min on Linux, and 7+ min on MacOS.
On Linux GH runner python 3.11, test timings before:
Test timings after:
Overall that's
328 seconds
faster on python 3.11 馃帀Timings vary between python versions and platforms, so the overall average speedup may differ.
Note about protobuf
This new model require that we use
protobuf<=3.20.x
, or otherwise a TypeError is thrown. There is a related thread on stackoverflow here.Here is the full traceback:
In future, we might be able to relax this pin if the
transformers
library is updated, or if we find an alternative Tokenizer model that was trained with a more recent version of protobuf.