Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #89

Closed
srghma opened this issue Aug 8, 2017 · 3 comments
Closed

Improvements #89

srghma opened this issue Aug 8, 2017 · 3 comments

Comments

@srghma
Copy link
Contributor

srghma commented Aug 8, 2017

What about:

  1. type checker (flow, ts)?
  2. babel-plugin-root-import (finnaly made it, was hard, but only with fork, info)
  3. better folder structure (this is interesting):
    3.1 move code to app
    3.2.1 it can be like in https://github.com/scalable-react/scalable-react-typescript-boilerplate
root -> app -> components/containers -> somename -> __tests__; index.js; styles.js; types.js; presentation.js (in contatiners also with actions, reducers, *.gql files and other)

3.2.2 oooooor ... atoms, molecules, organisms, templates, theme like in https://github.com/devinit/datahub (I think its same as components/containers but with more graduality, but I dont know, I started learning next week ago)) )
4. jest, snapshots, stories
5. inferno, preact or react-lite in production (or everywhere) ?

@Sly777
Copy link
Owner

Sly777 commented Aug 9, 2017

1 - Flow 👍
2 - I couldn't find what's the benefit of this.
3 - I think Folder structure is enough for all-size projects but possibly If you have any suggestions, We can talk about that :)
4 - Jest 👍
5 - I think It's not possible for now because of the next.js.

For some of your suggestions, I created issues each of them. I also tagged you so We can continue from there I think.

@srghma
Copy link
Contributor Author

srghma commented Aug 9, 2017

  1. its convenient (example: referring to /routes.js from deep nested components)
  2. why? examples are broken? O_O

@srghma
Copy link
Contributor Author

srghma commented Aug 10, 2017

next team is working to support typescript vercel/next.js#2250 vercel/next.js#2391
@Sly777 , what you think?

cool typescript lib https://github.com/typestyle/typestyle

@Sly777 Sly777 closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants