Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new Theme for Helloween Pumpkin Head #31

Closed
usulpro opened this issue Oct 29, 2016 · 6 comments
Closed

Create new Theme for Helloween Pumpkin Head #31

usulpro opened this issue Oct 29, 2016 · 6 comments

Comments

@usulpro
Copy link
Member

usulpro commented Oct 29, 2016

1 Open demo page

2 Play with settings in the Theme Editor

image

3 Save this theme

image

4 make a fork

5 Upload saved theme to example/LoremMaterial/

6 Make PR

Done!

@Radhikadua123
Copy link
Contributor

Hey! I would like to claim this .Can i get this? Thanks.

@usulpro
Copy link
Member Author

usulpro commented Oct 30, 2016

Hi, @Radhikadua123!
It's open for everybody, just make a PR

@Radhikadua123
Copy link
Contributor

I have created the new theme . I am finding it difficult to make a PR.Thanks

@usulpro
Copy link
Member Author

usulpro commented Oct 30, 2016

You can specify at what point you are stuck, so I can tell what to do?

@Radhikadua123
Copy link
Contributor

I am not getting what to write in the commit so as to have a good commit .I am also confused whether i have to push the saved file to my local repo or should i directly upload it by creating a branch example/LoremMaterial/ to the master branch.

@usulpro
Copy link
Member Author

usulpro commented Oct 30, 2016

After you create your theme via our demo-app

you need to download it as a .json file:
image

Then upload this file to your forked repo in example/LoremMaterial folder
image

When it's done. Submit a PR back to original repo
image

and

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants