-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need LSP workspace folders and events #4
Comments
I added refact/acceptCompletion method. Params: {snippet_telemetry_id: int}. snippet_telemetry_id came from refact/getCompletions |
The code already sends didopen and didchange events with the corresponding file name. |
|
Every time the user interacts with a new file refact_sessions calls load_document which sends a didOpen event. It even handles temporary unnamed files. |
@olegklimov is the issue that the plugin only provides open messages for files after the user interacts with them? Do you want the plugin to send didOpen messages on launch as well? |
I've tested quickly again, it's true "changed" arrives when I edit the code:
But I don't see "opened" whatever I do.
Sure. |
workspaces -- doesn't work, workspace_folders always empty list [] |
@olegklimov how do you want workspaces to work here? Are you sure didOpen isn't working I can see it's sending the message to the server and it's using the same mechanism as the ones that are working. |
So you only want a workspace to be created if the user directly opens a folder? I'm not sure what those opened messages are indicating? Are they showing didOpen messages being received on the server or are they showing something else entirely? |
reported
or starts Sublime so all the windows are restored back as they were the previous time
yes, didOpen messages sent by VSCode and received fine, demonstrating didOpen works on the server side |
Checked #16. |
Checked. |
Now refact-lsp receives:
But it needs workspace folders to index the files inside. I have two Sublime windows open, with different paths. Both need to be visible in workspace_folders.
Another problem is it needs these LSP events for specific files:
did_open
did_change
did_save
did_close
And finally for statistics we need
handle_v1_snippet_accepted
(actually an analog of this in LSP RPC) when a grey text code completion is accepted (Tab).The text was updated successfully, but these errors were encountered: