Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brail chart's complementation should be better. #13

Closed
smallkirby opened this issue Sep 16, 2021 · 1 comment · Fixed by #14
Closed

Brail chart's complementation should be better. #13

smallkirby opened this issue Sep 16, 2021 · 1 comment · Fixed by #14
Assignees

Comments

@smallkirby
Copy link
Owner

smallkirby commented Sep 16, 2021

Screenshot from 2021-09-16 18-58-12

MemMeter is ugly. Sequence such as [0, 3, 3] should be complemented in better way.

    // watch if 0-3 line is well complemented
    let d0: Vec<u32> = vec![0, 3, 0, 0, 0, 3, 0, 0];
    let d0: Vec<f64> = d0.into_iter().map(|d| d as f64).collect();
    let height = 4;
    let brail = b32::get_brails_complement(height, 0.0, 20.0, d0);
    show_brail(brail, height);
@smallkirby
Copy link
Owner Author

smallkirby commented Sep 16, 2021

In addition, [0, 3, 3, 3] looks below:
Screenshot from 2021-09-16 19-40-41

0 to 3 line overruns.

    // watch if 0-3 line doesn't overrun
    let d0: Vec<u32> = vec![0, 3, 3, 3];
    let d0: Vec<f64> = d0.into_iter().map(|d| d as f64).collect();
    let height = 4;
    let brail = b32::get_brails_complement(height, 0.0, 4.0, d0);
    show_brail(brail, height);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant