Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smallstep/cli libraries cannot be linked on windows #78

Closed
olix0r opened this issue Feb 20, 2019 · 2 comments
Closed

smallstep/cli libraries cannot be linked on windows #78

olix0r opened this issue Feb 20, 2019 · 2 comments

Comments

@olix0r
Copy link

olix0r commented Feb 20, 2019

We build our CLI across several platforms. When I try to introduce a dependency against this repo to use library code, we get the following error:

 ---> f44aec2ece40
Step 11/22 : RUN CGO_ENABLED=0 GOOS=darwin  go build -o /out/linkerd-darwin  -tags prod -ldflags "-s -w" ./cli
 ---> Running in 717aaaef4661
Removing intermediate container 717aaaef4661
 ---> 9e2bcfc7ccb7
Step 12/22 : RUN CGO_ENABLED=0 GOOS=linux   go build -o /out/linkerd-linux   -tags prod -ldflags "-s -w" ./cli
 ---> Running in 7c6187106257
Removing intermediate container 7c6187106257
 ---> bbe43df0a7d7
Step 13/22 : RUN CGO_ENABLED=0 GOOS=windows go build -o /out/linkerd-windows -tags prod -ldflags "-s -w" ./cli
 ---> Running in 7ad0c430bd98
# github.com/smallstep/cli/ui
../../smallstep/cli/ui/ui.go:205:25: cannot use syscall.Stdin (type syscall.Handle) as type int in argument to readline.IsTerminal
../../smallstep/cli/ui/ui.go:235:25: cannot use syscall.Stdin (type syscall.Handle) as type int in argument to readline.IsTerminal
The command '/bin/sh -c CGO_ENABLED=0 GOOS=windows go build -o /out/linkerd-windows -tags prod -ldflags "-s -w" ./cli' returned a non-zero code: 2

How feasible is it to make compilation succeed on windows?

@maraino
Copy link
Collaborator

maraino commented Feb 20, 2019

Hi @olix0r, we currently don't support windows, but depending on the packages that you're trying to link we can help you to fix it. Those lines in your output are not the only ones that cause problems on windows, so depending on the packages that you use, it's going to be problematic or not.

Can you give me the list of packages that you're using? Or better, can you link me to a branch that has that problem?

@dopey dopey added this to the Short Term Backlog milestone Apr 15, 2020
@sourishkrout
Copy link
Contributor

Hi @olix0r: As of our latest release https://github.com/smallstep/cli/releases/tag/v0.14.2 we are including a Windows build (step.exe) with every release going forward. While we haven't tested all of the step CLI's functionality thoroughly on Windows it will build from source now. Feel free to open new tickets for any issues you might encounter. Thank you!

@dopey dopey removed this from the Short Term Backlog milestone Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants