Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select Bundler to Use via CLI #328

Closed
FlorianRappl opened this issue Oct 5, 2020 · 1 comment
Closed

Select Bundler to Use via CLI #328

FlorianRappl opened this issue Oct 5, 2020 · 1 comment
Assignees
@FlorianRappl
Labels
cli Concerns the piral-cli application. enhancement New feature or request parcel Concerns the integration of the Parcel bundler in the CLI. webpack Concerns the integration of the Webpack bundler in the CLI.
Milestone
0.12.3

Comments

@FlorianRappl
Copy link
Contributor

Description

In case of multiple installed bundlers (or if none is installed it) the bundler should (or needs to be) selected via a new CLI option called --bundler.

Usually, this option should not be required, as there is just one bundler installed.

Background

In case of multiple installed bundlers some bundler is auto-selected (usually the first one found in node_modules). This is not desired - it should be more predictable.

Discussion

Should the option be required in case of multiple bundlers? Should the option actually try to install the selected bundler (if any) if none found (e.g., if --bundler webpack, but only piral-cli-parcel is installed, should piral-cli-webpack be installed)?
@FlorianRappl FlorianRappl added enhancement New feature or request cli Concerns the piral-cli application. in-implementation The item is currently being implemented. webpack Concerns the integration of the Webpack bundler in the CLI. parcel Concerns the integration of the Parcel bundler in the CLI. labels Oct 5, 2020
@FlorianRappl FlorianRappl added this to the 0.12.3 milestone Oct 5, 2020
@FlorianRappl FlorianRappl self-assigned this Oct 5, 2020
@FlorianRappl FlorianRappl added in-testing The item is already out in preview and can be tested. and removed in-implementation The item is currently being implemented. labels Oct 5, 2020
@FlorianRappl
Copy link
Contributor Author

Landed in develop. Shipped in the preview @next.

@FlorianRappl FlorianRappl removed the in-testing The item is already out in preview and can be tested. label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FlorianRappl FlorianRappl

Labels
cli Concerns the piral-cli application. enhancement New feature or request parcel Concerns the integration of the Parcel bundler in the CLI. webpack Concerns the integration of the Webpack bundler in the CLI.
Projects
None yet
Milestone
0.12.3
Development

No branches or pull requests
1 participant
@FlorianRappl