Angular SharedModule problem

[prepfarm]

Bug Report

For more information, see the CONTRIBUTING guide.

Prerequisites

• Can you reproduce the problem in a MWE?
• Are you running the latest version?
• Did you perform a search in the issues?

Environment Details and Version

Piral 1.3.3

Description

import { SharedModule } from 'piral-ng/common'; fails as it says that it cannot find module, even tho it's shared module from app shell. Installing it separately in the pilet, results in errors that @types/react isn't installed. Even after instaling types, errors are shown.

Steps to Reproduce

1. Initialize Angular pilet
2. Add SharedModule inside of @NgModule

Expected behavior

To be able to use <extension-component>

Actual behavior

Throws errors on build/debug once it's imported.

[FlorianRappl]

Can you please show a MWE and have your steps to reproduce filled out properly?

For instance, "initialize Angular pilet" - what does that mean? Are you using the template? Also, keep in mind that the package is piral-ng-common, not piral-ng/common, which is the old / outdated shim.

[prepfarm]

Thanks for quick reply! I was able to get it working by using piral-ng-common and not piral-ng/common which I saw in many examples and also in the docs (see under For pilet authors)

[FlorianRappl]

Thanks for the info - yes the peer dependencies (look at top of the document) are mentioned, however, as you stated it should be more clear that

npm i piral-ng-common

is mostly needed (otherwise some version is installed which might fit your Angular version or not - in the latter case leading to problems).

[FlorianRappl]

Re-opened as documentation task.

[FlorianRappl]

Landed in develop.