Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Declaration Merging Instead of Generics #72

Closed
FlorianRappl opened this issue Sep 3, 2019 · 1 comment
Closed

Use Declaration Merging Instead of Generics #72

FlorianRappl opened this issue Sep 3, 2019 · 1 comment
Assignees
Labels
core Concerns the piral-core library. enhancement New feature or request framework Concerns the full piral library / framework. pilets Concerns the API of the pilets.
Milestone

Comments

@FlorianRappl
Copy link
Contributor

Description

The current API uses generics, which makes it hard to deal with it on multiple layers. Especially from a pilet POV its a huge pain.

We need a better way - that originates the API already from piral-core and only extends it all the way.

Background

Right now the app shell should / would alias the "final" API and use it in generics. As such MyAppShellApi becomes a thing. It should not be. It will prevent cross Piral solutions (pilets) independent of any pattern libraries or other dependencies - just because the APIs are named differently (but share the same core or are even 100% the same).

Discussion

This will have an impact on how pilet API extensions are written. The intention here is not to make things more complicated or worse, but to simplify.

By using declaration merging we are on the road to have a single Piral instance only (which makes sense - multiple instances are academic anyway).

@FlorianRappl FlorianRappl added enhancement New feature or request core Concerns the piral-core library. pilets Concerns the API of the pilets. framework Concerns the full piral library / framework. labels Sep 3, 2019
@FlorianRappl FlorianRappl added this to the 0.8.0 milestone Sep 3, 2019
@FlorianRappl FlorianRappl self-assigned this Sep 7, 2019
@FlorianRappl
Copy link
Contributor Author

Landed in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Concerns the piral-core library. enhancement New feature or request framework Concerns the full piral library / framework. pilets Concerns the API of the pilets.
Projects
None yet
Development

No branches or pull requests

1 participant