Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code enhancement in Teams Page #274

Closed
imyashadulkar opened this issue Sep 1, 2020 · 21 comments
Closed

Code enhancement in Teams Page #274

imyashadulkar opened this issue Sep 1, 2020 · 21 comments
Assignees

Comments

@imyashadulkar
Copy link

imyashadulkar commented Sep 1, 2020

Path: community_app_boilerplate/lib/ui/screens/Teams.dart

We have stored the Teams Images in assets. We could use free storage services and host it on a server and instead of AssetImage we could use it CacheNetworkImage
It would reduce app size and also since it is a cache network Image so the image will be loaded only when the image is changed, other times the widget would directly take the image from the cache itself.
Also wherever you have used Network Image. I would like to use the CacheNetworkImage widget.
If you allow me, I would like to do these changes.

@github-actions
Copy link

github-actions bot commented Sep 1, 2020

We shall look into this issue. Thanks for bringing it to our notice!

@himanshusharma89
Copy link
Collaborator

Sure @elaishane, should I assign it to you?

@lordvins226
Copy link
Contributor

i can take this. you can upload images on free storage and give link?

@imyashadulkar
Copy link
Author

Yes

@himanshusharma89
Copy link
Collaborator

@elaishane You are saying yes to work on this issue?

@imyashadulkar
Copy link
Author

Yes

@imyashadulkar
Copy link
Author

@himanshusharma89 I would be needing a storage location, it their image links.

@himanshusharma89
Copy link
Collaborator

@elaishane Do you have a platform in mind for the deployment of the images?

@imyashadulkar
Copy link
Author

I think github would do.

@himanshusharma89
Copy link
Collaborator

Okay @elaishane, so I guess all the assets are already uploaded you can work on it right away check out the assets folder.

@imyashadulkar
Copy link
Author

Sure. Thank you

@himanshusharma89
Copy link
Collaborator

Hey @elaishane, any update? and should I assign it to you?

@imyashadulkar
Copy link
Author

I am working on it. It would be completed by tomorrow evening

@himanshusharma89
Copy link
Collaborator

Thanks for the update @elaishane. Assigning it to you.

@imyashadulkar
Copy link
Author

Hey, @himanshusharma89 I will be needing a link for the images. Like Twitter, Facebook, GitHub but separate repo. A link that would not change even with new changes

@himanshusharma89
Copy link
Collaborator

@imyashadulkar
Copy link
Author

Ok

@imyashadulkar imyashadulkar removed their assignment Oct 21, 2020
@Saransh-cpp
Copy link
Contributor

Saransh-cpp commented Jan 28, 2021

Hey @himanshusharma89 , can I work on this issue as no one is working on it?

@himanshusharma89
Copy link
Collaborator

Sure @Saransh-cpp

@Saransh-cpp
Copy link
Contributor

Should I create a new branch? Also after adding cached_network_image dependency in the pubspec.yaml file and running the code in my system, it automatically edited .idea/libraries/Dart_Packages.xml file, should I add this in git or should I push changes without adding this edited file, keeping the old file? Please guide

@himanshusharma89
Copy link
Collaborator

@Saransh-cpp Yeah, create a new branch. And the changes you mentioned are already ignored using .gitignore. You can start working on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants