New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code enhancement in Teams Page #274
Comments
We shall look into this issue. Thanks for bringing it to our notice! |
Sure @elaishane, should I assign it to you? |
i can take this. you can upload images on free storage and give link? |
Yes |
@elaishane You are saying yes to work on this issue? |
Yes |
@himanshusharma89 I would be needing a storage location, it their image links. |
@elaishane Do you have a platform in mind for the deployment of the images? |
I think github would do. |
Okay @elaishane, so I guess all the assets are already uploaded you can work on it right away check out the assets folder. |
Sure. Thank you |
Hey @elaishane, any update? and should I assign it to you? |
I am working on it. It would be completed by tomorrow evening |
Thanks for the update @elaishane. Assigning it to you. |
Hey, @himanshusharma89 I will be needing a link for the images. Like Twitter, Facebook, GitHub but separate repo. A link that would not change even with new changes |
Hi @elaishane, what about these links: You can directly use them in NetworkImage |
Ok |
Hey @himanshusharma89 , can I work on this issue as no one is working on it? |
Sure @Saransh-cpp |
Should I create a new branch? Also after adding cached_network_image dependency in the pubspec.yaml file and running the code in my system, it automatically edited .idea/libraries/Dart_Packages.xml file, should I add this in git or should I push changes without adding this edited file, keeping the old file? Please guide |
@Saransh-cpp Yeah, create a new branch. And the changes you mentioned are already ignored using .gitignore. You can start working on the issue. |
Path: community_app_boilerplate/lib/ui/screens/Teams.dart
We have stored the Teams Images in assets. We could use free storage services and host it on a server and instead of AssetImage we could use it CacheNetworkImage
It would reduce app size and also since it is a cache network Image so the image will be loaded only when the image is changed, other times the widget would directly take the image from the cache itself.
Also wherever you have used Network Image. I would like to use the CacheNetworkImage widget.
If you allow me, I would like to do these changes.
The text was updated successfully, but these errors were encountered: