Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img srcset is not a correct relative path #47

Closed
smarie opened this issue Apr 12, 2022 · 1 comment
Closed

img srcset is not a correct relative path #47

smarie opened this issue Apr 12, 2022 · 1 comment

Comments

@smarie
Copy link
Owner

smarie commented Apr 12, 2022

At the bottom of this example : https://smarie.github.io/python-m5p/generated/gallery/1_simple_1D_demo/

The image is not displayed correctly :

image

(from smarie/python-m5p#8)

It seems that this is dues to the srcset attribute of the img, that is not relative.

<img alt="Decision Tree Regression" class="mkd-glr-single-img" src="../images/mkd_glr_1_simple_1D_demo_001.png" srcset="/generated/gallery/images/mkd_glr_1_simple_1D_demo_001.png">
@smarie
Copy link
Owner Author

smarie commented Apr 12, 2022

The bug is fixed if we replace the path with a relative one: srcset="../images/mkd_glr_1_simple_1D_demo_001.png".

Let's hope that the fix can work both for local and gh-pages deploy !

@smarie smarie closed this as completed in 2ae9f35 May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant