Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@autofields does not take definition order into account #76

Closed
smarie opened this issue Sep 22, 2020 · 1 comment
Closed

@autofields does not take definition order into account #76

smarie opened this issue Sep 22, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@smarie
Copy link
Owner

smarie commented Sep 22, 2020

Consider this:

from pyfields import autofields, get_fields

@autofields
class Foo:
    c: int
    b: str = "hello"

get_fields(Foo)  # <-- (<NativeField: Foo.b>, <NativeField: Foo.c>)

So the order in which the fields are returned is wrong.

@smarie smarie added the bug Something isn't working label Sep 22, 2020
@smarie
Copy link
Owner Author

smarie commented Sep 22, 2020

After investigating, this bug only happens when there are attributes that do not have default values (only an annotation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant