Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove execution_time from the results_bag fixture and use 'duration_ms' instead of 'duration' in pytest info #6

Closed
smarie opened this issue Nov 14, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@smarie
Copy link
Owner

smarie commented Nov 14, 2018

It seems that the best duration estimate is the one from pytest because it is really made right before/after the call. However it is not clear that the number was in seconds, so it is probably preferred to have a number of milliseconds and an explicit name.

I will open a separate issue on pytest concerning the way these durations are measured by pytest.

@smarie smarie added the enhancement New feature or request label Nov 14, 2018
@smarie smarie changed the title Remove execution_time from the resutls_bag fixture and use 'duration_ms' instead of 'duration' in pytest info Remove execution_time from the results_bag fixture and use 'duration_ms' instead of 'duration' in pytest info Nov 14, 2018
@smarie smarie closed this as completed in c67838c Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant