New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erroneous comma suggestion #20

Open

pgjones opened this issue Mar 22, 2017 · 1 comment

Contributor

pgjones commented Mar 22, 2017

In the following snippet

result = '\n\n'.join(
        '<p>%s</p>' % p.replace('\n', '<br>\n')
        # FIXME: Is str() necessary here?
        for p in PARAGRAPH_RE.split(str(escape(value)))
    )

The text was updated successfully, but these errors were encountered:

Contributor

mxr commented Nov 1, 2017

See https://github.com/smarkets/flake8-strict/blob/d91fc13/README.rst#limitations

You'd want to use a generator comprehension inside join i.e.

-result = '\n\n'.join(
+result = '\n\n'.join((
     '<p>%s</p>' % p.replace('\n', '<br>\n')
     # FIXME: Is str() necessary here?
     for p in PARAGRAPH_RE.split(str(escape(value)))
-)
+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment