Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a field to store information about occupied spots (e.g. occupiedSpotNumber) #15

Closed
jpnbastos opened this issue Nov 25, 2020 · 5 comments

Comments

@jpnbastos
Copy link

While developing an application that processed entities stored as OnStreetParking, we noticed that we can store the information about the total number of spot and the available number of parking spots.

Our application is mainly concerned about showing the current occupancy of the parking area. Which we are computing as the number of vehicles located in that OnStreetParking.

We solved this currently by making Available = Total - Occupied. However, this as a few downfalls:

  • In our case sometimes more vehicles are parked than there are spots available, so Available becomes a negative number.
  • If the parking capacities are updated then we must also take care of accordingly updating the Available field, which if not accounted for can lead to faulty issues.

For this reason, we wanted to know if it is possible to add an extra optional field to the datamodel such as occupiedSpotNumber?

Thanks :)

@albertoabellagarcia
Copy link
Contributor

it is possible as long as the rest of the contributors do not show objections. Anyhow the licence of the data models allows you to do it always.

@albertoabellagarcia
Copy link
Contributor

not seeing incoveniences, could you launch a PR?

@jpnbastos
Copy link
Author

Okay, we will do so :)

@jpnbastos
Copy link
Author

What is the current flow for a PR? Do I open a branch from this repo? Do I need permission?

I have the code ready.

@albertoabellagarcia
Copy link
Contributor

I see that you have already created the PR. Let us review it. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants