Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIOP Response Payload Conflict #22

Closed
jdkizer9 opened this issue Dec 11, 2020 · 2 comments
Closed

SIOP Response Payload Conflict #22

jdkizer9 opened this issue Dec 11, 2020 · 2 comments

Comments

@jdkizer9
Copy link

jdkizer9 commented Dec 11, 2020

There appears to be a conflict between the SIOP Response format in the reference implementation and what's in the docs. The reference implementation payload includes a did property, whereas the payload format in the docs includes a sub_jwk property.

EDIT: I think I overlooked some things. The docs do include a did property, so just wondering if we should be including the sub_jwk.

@jdkizer9 jdkizer9 changed the title SIOP Response Format Conflict SIOP Response Payload Conflict Dec 11, 2020
@madaster97
Copy link

I think we include this because it's required for Openid Core's SIOP Response.

As for why it's in OIDC, I believe it's because that framework doesn't have a PKI setup (hence DIDs in DID SIOP). It may be worth having this explicitly removed in DID SIOP, since there is a PKI built in. I could also be missing something though!

@jmandel
Copy link
Member

jmandel commented Jan 21, 2021

We have a did and sub_jwk property currently documented. Some of the details may change as DID-SIOP progresses through its next round of standardization. For the moment, I don't think we have anything to do on this issue, but please re-open if I'm missing something.

@jmandel jmandel closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants