Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniswap v1 #2

Closed
aelmanaa opened this issue Mar 21, 2022 · 2 comments · Fixed by #4
Closed

Uniswap v1 #2

aelmanaa opened this issue Mar 21, 2022 · 2 comments · Fixed by #4
Assignees
@aelmanaa
Labels
in progress

Comments

@aelmanaa
Copy link

Hello,

I can take care of implementing a minimal version of uniswap v1. Found several nice and detailed examples online so I can give it a try. We can have:

  • Factory to create several exchanges
  • Exchange contract (ETH vs ERC20 Token):
    • Add liquidity
    • Get Reserve of token
    • Get current price of token ( constant product formula)
    • Buy / sell token (swap functions - including fees)
    • Manage liquidity tokens
@PatrickAlphaC
Copy link
Contributor

Holy shit that would be nuts. Would love to see this.

We could call it Swap.sol (similar to our naming agnostic other ones)

@aelmanaa
Copy link
Author

aelmanaa commented Apr 1, 2022

ok cool, will work on it !

@aelmanaa aelmanaa self-assigned this Apr 1, 2022
@aelmanaa aelmanaa linked a pull request Apr 10, 2022 that will close this issue
Add Uniswap v1 with LP implementation #4
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aelmanaa aelmanaa

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Uniswap v1 with LP implementation smartcontractkit/defi-minimal
2 participants
@aelmanaa @PatrickAlphaC