Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic options contract and test file #3

Merged
merged 4 commits into from Apr 7, 2022
Merged

Basic options contract and test file #3

merged 4 commits into from Apr 7, 2022

Conversation

TobiasBK
Copy link
Contributor

Basic options contract that allows for covered calls and puts. The underlying is ETH and the payment is in DAI. This is a work in progress. I wanted to share what I had so far. I haven't written any test yet, will do in the next few days. Let me know what you think.

@PatrickAlphaC
Copy link
Contributor

This is so cool!!!!!

Yes, would love to see some tests and would be happy to merge. The use of the price feeds to get the conversion for the options is awesome!!!

@TobiasBK
Copy link
Contributor Author

TobiasBK commented Apr 4, 2022

I've added deploy script. Updated contract comments and fixed some basic errors. I also wrote some initial tests. A lot more tests can be written, but I won't be able to get to it until next weekend.

Hopefully this contract is interesting enough to get others to make it better. :)

Let me know if you want anything changed, see any mistakes (there are probably a few), etc.

@PatrickAlphaC PatrickAlphaC merged commit 8c30a29 into smartcontractkit:main Apr 7, 2022
@PatrickAlphaC
Copy link
Contributor

Looks good!!

I'll give it a deeper dive in the coming month, we'll leave it as in progress for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants