Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secrets module #277

Closed
justinkaseman opened this issue Jan 27, 2021 · 1 comment
Closed

Secrets module #277

justinkaseman opened this issue Jan 27, 2021 · 1 comment

Comments

@justinkaseman
Copy link
Collaborator

We can't commit API keys to the public repository.

But, you are right that integration tests set like this are not too usable. We want to somehow start integration tests for all adapters at once, but then how do we inject a different API key to each.

One possible solution would be to have a secrets.json configured with all secrets required for integration tests. Then every test can read from there.

Originally posted by @krebernisak in #218 (comment)
@justinkaseman
Copy link
Collaborator Author

Realized this is a duplicate. Disregard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinkaseman