Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in hardhat.config.js file #99

Closed
luislucena16 opened this issue May 23, 2022 · 6 comments
Closed

Fix in hardhat.config.js file #99

luislucena16 opened this issue May 23, 2022 · 6 comments
Labels
good first issue Good for newcomers

Comments

@luislucena16
Copy link
Contributor

luislucena16 commented May 23, 2022

hey @PatrickAlphaC I have a doubt about line 100, it is calling the RandomNumberConsumer but I should assign the V2 at the end of the name, please correct me if I am wrong.

fix

@zeuslawyer
Copy link
Contributor

HI @luislucena16! Can you please link to the file you're referring to?

thanks!

@luislucena16
Copy link
Contributor Author

luislucena16 commented May 23, 2022

hi @zeuslawyer! Sure, https://github.com/smartcontractkit/hardhat-starter-kit/blob/main/hardhat.config.js line 100.

thank you for your response!

@zeuslawyer
Copy link
Contributor

@luislucena16 - no problem!

I believe what you're saying makes sense. Do you want to submit a PR? In case you've never submitted one, you can fork this repo (it will be called the "upstream" repo) and then you can follow this process:

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

Let me know if you want to try that :)

@luislucena16
Copy link
Contributor Author

yes of course, I will open the PR and make the changes!

thanks :) @zeuslawyer

@luislucena16 luislucena16 changed the title Fix in hardhatconfig.js file Fix in hardhat.config.js file May 23, 2022
@luislucena16
Copy link
Contributor Author

hey @zeuslawyer I have already opened the PR, here is the link #100

@zeuslawyer zeuslawyer added the good first issue Good for newcomers label May 24, 2022
@zeuslawyer
Copy link
Contributor

zeuslawyer commented May 24, 2022

thanks @luislucena16 . PR approved.
#100

Appreciate your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants