Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to control the download #17

Merged
merged 2 commits into from Jun 19, 2017
Merged

Conversation

cabarnes
Copy link
Member

@cabarnes cabarnes commented Jun 6, 2017

Allows the caller of the download method to get the response object
back to download the item as needed. This allows the caller to
iteratively download in whatever chunk size is desired, to download to
whatever location is desired, etc.

Allows the caller of the 'download' method to get the response object
back to download the item as needed. This allows the caller to
iteratively download in whatever chunk size is desired, to download to
whatever location is desired, etc.
@coveralls
Copy link

coveralls commented Jun 6, 2017

Coverage Status

Coverage decreased (-1.03%) to 70.161% when pulling e12c5b9 on generic-download-support into cdc333f on master.

@coveralls
Copy link

coveralls commented Jun 12, 2017

Coverage Status

Coverage decreased (-1.03%) to 70.161% when pulling a6bc2d0 on generic-download-support into 4db0dfc on master.

Copy link
Contributor

@Ryanb58 Ryanb58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cabarnes cabarnes merged commit c04d475 into master Jun 19, 2017
@cabarnes cabarnes deleted the generic-download-support branch June 19, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants