feat: use native navigation instead of getX navigation #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschaer92
reviewed
May 6, 2024
packages/fluorflow/example/lib/views/detail/detail_viewmodel.dart
Outdated
Show resolved
Hide resolved
buehler
pushed a commit
that referenced
this pull request
May 7, 2024
# [3.0.0](v2.0.1...v3.0.0) (2024-05-07) ### Features * use native navigation instead of getX navigation ([#6](#6)) ([e9cf309](e9cf309)) ### BREAKING CHANGES * The `DialogService` was deleted. Dialog related methods are now in the `NavigationService`. * The `BottomSheetService` was deleted. All related methods are now in the `NavigationService`. * the close methods for dialog and sheet (`closeDialog` and `closeSheet`) are removed. They are unified in the method `closeOverlay` in the `NavigationService`. * Since getX is removed, the base logic of the entry point in the app could be simplified. Instead of the key and observer being methods, they are now static initialized fields on the navigation service. BRAKING CHANGE: The `preventDuplicates` parameter for the navigation method is gone. Currently, with native navigation, the user of the package is responsible to have an overview of the navigation stack.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes get (getX) as the underlying navigation engine.
Since GetX also routes with the native navigation stack,
this can be directly used instead of passed to get which
then in turn passes it to flutter. While doing this, the services
were redesigned and all navigation related matters are now in
the navigation service only.
BREAKING CHANGE: The
DialogServicewas deleted.Dialog related methods are now in the
NavigationService.BREAKING CHANGE: The
BottomSheetServicewas deleted.All related methods are now in the
NavigationService.BREAKING CHANGE: the close methods for dialog and
sheet (
closeDialogandcloseSheet) are removed. Theyare unified in the method
closeOverlayin theNavigationService.BREAKING CHANGE: Since getX is removed, the base logic of
the entry point in the app could be simplified. Instead of
the key and observer being methods, they are now static
initialized fields on the navigation service.
BRAKING CHANGE: The
preventDuplicatesparameter for thenavigation method is gone. Currently, with native
navigation, the user of the package is responsible to
have an overview of the navigation stack.