Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rule-set): Add member access as well as function name #4

Merged
merged 3 commits into from
Mar 26, 2018

Conversation

buehler
Copy link
Member

@buehler buehler commented Mar 26, 2018

Adding the following rules:

  • member-access: force explicit naming of public private and protected
  • jsx-no-lambda: allow lambda expressions in JSX
  • function-name: allow (expecially for default imports) an uppercase function name

@buehler buehler requested a review from mfeltscher March 26, 2018 12:18
Copy link
Member

@mfeltscher mfeltscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add documentation to README

@buehler
Copy link
Member Author

buehler commented Mar 26, 2018

This will be a breaking change (due to the member-access rule)

@buehler
Copy link
Member Author

buehler commented Mar 26, 2018

I'd suggest the following commit msg:

BREAKING CHANGE: This adds `member-access` as a required rule.
This rule forces the user to add `public`, `private` and `protected` modifiers
to their class members. To migrate, install the new version and use the
given visibility members on classes.

@mfeltscher mfeltscher merged commit 626d1b0 into master Mar 26, 2018
@mfeltscher mfeltscher deleted the feat/improvements branch March 26, 2018 13:28
@deniaz
Copy link
Member

deniaz commented Mar 27, 2018

function-name was breaking as well ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants