Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartsheet Javascript SDK Includes Vulnerable Node.js Version 2.88.1 (CVE-2023-28155) #30

Closed
eric-french opened this issue Apr 28, 2023 · 4 comments · Fixed by #36
Closed

Comments

@eric-french
Copy link

=== Description ===
CVE-2023-28155 (https://nvd.nist.gov/vuln/detail/CVE-2023-28155) was discovered via Node Package Manager which manages Open Source dependencies like the Smartsheet NodeJS SDK.

=== Steps to Repro ===
Node Package Manager has an audit tool that cross references any open source dependencies, and their own nested open source dependencies, against the National Vulnerability Database. This audit tool found that the Smartsheet NodeJS SDK depends on a vulnerable version of request.

=== Severity ===
Low, due within 180 days

=== Remediation ===
https://github.com/smartsheet/smartsheet-javascript-sdk/blob/mainline/package.json

=== Addt'l Info ===
Reach out to #askus-prodsec for assist

@Scomodev
Copy link
Contributor

On a quick look at this, we should fully move off of request as it is deprecated since Feb 2020 and no longer accepting changes, including a patch for this very same vulnerability.

@mattmeyerink mattmeyerink linked a pull request Aug 22, 2023 that will close this issue
@mattmeyerink
Copy link
Contributor

Marking this issue complete. request has been removed in favor of axios as of release v3.1.3.

@mattmeyerink
Copy link
Contributor

Re-opening this issue as the initial change to replace request with axios needed to be reverted in v3.1.4

@mattmeyerink mattmeyerink reopened this Aug 22, 2023
@Scomodev
Copy link
Contributor

Marking as complete again. Version 4.0.1 now addresses this issue by replacing request with axios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants