Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting other languages resets selected sorting/items per page setting #724

Closed
Algorithman opened this issue May 30, 2023 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@Algorithman
Copy link
Contributor

Algorithman commented May 30, 2023

Describe the bug
Language selector resets sorting/items per page arguments when switching language.

To Reproduce
Steps to reproduce the behavior:

  • Add a few languages to the shop
  • go into any category with products
  • select non-default sorting or items per page setting in the dropdowns
  • switch language

Expected behavior
A clear and concise description of what you expected to happen.
Shop should keep the sorting and items per page setting.
At the moment the URL is only created correctly for the already selected language (e.g. ?o=10&s=72) but these parameters are omitted for all other available languages.

Screenshots
If applicable, add screenshots to help explain your problem.

<a href="[/set-language/1/?returnUrl=gestreift](https://testshop.local/set-language/1/?returnUrl=gestreift)" title="Deutsch (DE)" rel="nofollow" class="dropdown-item" data-selected="false" data-abbreviation="Deutsch">
                    <img src="[/images/flags/de.png](https://testshop.local/images/flags/de.png)" alt="de.png" />
                <span>Deutsch</span>
            </a>
            <a href="[/set-language/2/?returnUrl=striped%3Fo%3D10%26s%3D72](https://testshop.local/set-language/2/?returnUrl=striped%3Fo%3D10%26s%3D72)" title="Englisch (Vereinigte Staaten) (EN)" rel="nofollow" class="dropdown-item disabled" data-selected="true" data-abbreviation="Englisch (Vereinigte Staaten)">
                    <img src="[/images/flags/us.png](https://testshop.local/images/flags/us.png)" alt="us.png" />
                <span>English</span>
            </a>
            <a href="[/set-language/3/?returnUrl=a-rayures](https://testshop.local/set-language/3/?returnUrl=a-rayures)" title="Französisch (Frankreich) (FR)" rel="nofollow" class="dropdown-item" data-selected="false" data-abbreviation="Französisch (Frankreich)">
                    <img src="[/images/flags/fr.png](https://testshop.local/images/flags/fr.png)" alt="fr.png" />
                <span>Français</span>
            </a>

Desktop (please complete the following information):

  • OS: Windows (probably all)
  • Browser: All
@Algorithman Algorithman changed the title Selecting other languages reset selected sorting/items per page setting Selecting other languages resets selected sorting/items per page setting May 30, 2023
@muratcakir muratcakir added this to the 5.0.5 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants