Skip to content
This repository has been archived by the owner on Jun 4, 2019. It is now read-only.

Support Unicode encodings #1

Closed
mholt opened this issue Nov 7, 2014 · 2 comments
Closed

Support Unicode encodings #1

mholt opened this issue Nov 7, 2014 · 2 comments

Comments

@mholt
Copy link
Contributor

mholt commented Nov 7, 2014

The encoding currently only supports ASCII (oops - forgot to upgrade that) since each character only gets 1 byte. This should be expanded to more bytes when the user wants to encode trees with Unicode characters.

However, since this greatly increases the file size and may not be necessary, so this option should be configurable.

@sqs
Copy link

sqs commented Feb 4, 2015

Just ran into this issue (it was causing a stack overflow--a "stack growth" panic). I'm fine with just using ASCII, for my use cases, but would you accept a PR that returned an error or panicked in Insert if non-ASCII is added?

@mholt
Copy link
Contributor Author

mholt commented Feb 4, 2015

Hey Quinn, I'm sure we'd love a PR for that. It's a decent stop-gap. @mdwhatcott or @joliver might be able to merge it in for ya.

@mholt mholt closed this as completed Jun 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants