'ShouldEqual' should panic when trying to compare different types

[mattwarren1234]

The below example should panic:

So("2", ShouldEqual, 2)

Instead it displays the following message (test fails, for seemingly no reason):

[mdwhatcott]

Thanks for bringing this to my attention.

Note to self: This is actually an issue with the assertions package, not the GoConvey project.

Hmm, I disagree with the idea that the assertions package or even the convey package should panic in a failure scenario. I would say we just need more helpful error message. Something like:

Expected: '2' (string)
Actual:   '2' (int)
(Should be equal)

Keep in mind that you can currently compare the int value 2 with the int64 value 2 without any problems. I wouldn't want to disrupt that behavior.

I'll take a look at this.

[mattwarren1234]

Yeah, listing types would be even more helpful!

[mdwhatcott]

Pull the latest:

go get -u github.com/smartystreets/assertions