Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore the /dist folder #1136

Closed
adampatterson opened this issue Nov 20, 2015 · 4 comments
Closed

Don't ignore the /dist folder #1136

adampatterson opened this issue Nov 20, 2015 · 4 comments

Comments

@adampatterson
Copy link

So I am using require.js with Bower and locally everything is fine.

I had a look at my bower settings for Owl and It is using 'latest' Cool, Check my site out on my server and Owl is now missing. I do a bit of digging and see that the /dist folder is missing.

Bower/Grunt everything and the folder is still ignored.

Basically by ignoring the /dist folder makes this package unusable without moving files around.

https://github.com/smashingboxes/OwlCarousel2/blob/develop/.gitignore#L12

@korywka
Copy link

korywka commented Nov 26, 2015

+1

@greg5green
Copy link
Contributor

The dist folder is included in beta 3. https://github.com/smashingboxes/OwlCarousel2/tree/2.0.0-beta.3

@korywka
Copy link

korywka commented Dec 1, 2015

Why this ticket is closed? I still see /dist in gitignore in last version. It should be removed from gitignore.

@greg5green
Copy link
Contributor

The Bower releases are based off the master branch, which does not have dist in it's gitignore.

This was changed in 1333765. Although beta 3 is one commit behind master at the moment and does not include this commit, it still includes the dist directory when doing a bower install when installing either a specific version, like ~2.0.0-beta.3 or just the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@adampatterson @korywka @greg5green and others