Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column expanded in meta.csv contains NaN values #115

Open
rubencart opened this issue Apr 9, 2024 · 4 comments
Open

Column expanded in meta.csv contains NaN values #115

rubencart opened this issue Apr 9, 2024 · 4 comments
Labels
question Further information is requested

Comments

@rubencart
Copy link

rubencart commented Apr 9, 2024

What do these mean?

import pandas as pd
df = pd.read_csv('meta.csv')
print(df.expanded.isna().sum())
Out[5]: 5878
@jonnybluesman
Copy link
Member

Hi @rubencart, please be more specific when you describe any issue in ChoCo.

@jonnybluesman jonnybluesman added the question Further information is requested label Apr 10, 2024
@rubencart
Copy link
Author

Sorry, I thought the question was clear. The provided meta.csv file in its expanded column contains 3 values: True, False and something that pandas considers as NaN. My question is what do these 3 values represent?

  1. What does it mean for a song to be expanded (could not find this explained anywhere)
  2. What does it mean for a song to have expanded == NaN vs expanded == False?
df = pd.read_csv('data/.../meta.csv')
(df.expanded == True).sum()
Out[1]: 8202
(df.expanded == False).sum()
Out[2]: 6006
df.expanded.isna().sum()
Out[3]: 5878
len(df)
Out[4]: 20086
8202 + 6006 + 5878
Out[5]: 20086

@jonnybluesman
Copy link
Member

Thanks for clarifying. At the moment, the script generating the meta.csv iterates over all JAMS files and extracts the information that are summarised in the CSV. This may still contain some bugs if the respective fields in JAMS are not consistent, which necessitates some checks for the expansion attribute (it is probably a simple bug when parsing). I will keep this issue for us to check.

Instead, to address your first question, expansion (for a score-based annotation) means that the score "has been expanded" to flatten out all the repetitions. For example, if a sequence of bars (with chord annotations) has a repeat sign, what we basically do is to expand the score by actually unrolling the repetition (as if the score is performed). This happens for all the ireal-pro subset for example.

@rubencart
Copy link
Author

I see, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants