Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long.js uses nonstandard export mechanisms #1

Open
DavidSouther opened this issue Sep 23, 2022 · 3 comments
Open

long.js uses nonstandard export mechanisms #1

DavidSouther opened this issue Sep 23, 2022 · 3 comments

Comments

@DavidSouther
Copy link

DavidSouther commented Sep 23, 2022

Long uses a non-standard export = Long; AMD default export. This should be export default Long;

@DavidSouther
Copy link
Author

With a couple issues on Long's page:

dcodeIO/long.js#103
dcodeIO/long.js#109

@smaye81
Copy link
Owner

smaye81 commented Sep 28, 2022

Hey David, long time no talk! Hope all is well.

Yeah, this repro example was something I put up related to this TypeScript issue. I see why it's failing, but I'm more concerned with why it's not working with esModuleInterop. Check that linked issue for more details (and if you have any ideas, I'm all ears :)

@DavidSouther
Copy link
Author

The main issue with ESM and nodenext/node16 mode is TypeScript refusing to add .js extensions to the generated import statements in the compiled files.

Man this issue is causing soooo muuuuch paaaaiiiinnn for the JS/TS community haha! I see why this is a TS issue now, it really should be "smart" enough to figure out in spite of long.js doing silly things.

Things are going great! Been in Seattle for a while, at AWS now doing Rust SDK examples & guides. It's a change of pace but super interesting! How are you? Buf seems like a super interesting project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants