Put the Filters page content into a paper #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lorenzov96 the reason why now it's more spaced vertically it's because at line 335 there is a |
danielecalda
pushed a commit
that referenced
this pull request
Jun 20, 2022
Thanks for the contribution @giulioz 🍻
danielecalda
pushed a commit
that referenced
this pull request
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current standard for admin pages is to have the content into a Paper component, to separate the content from the background:
The Filters page, though, doesn't follow this and throws everything in the background instead:
This small PR fixes the styling of the Filters page, putting all the content into a Paper component. Furthermore, it moves the add button to the
breadcrumbsControlsprop of Layout, which was designed for this purpose and adds a tooltip for it.