Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds parallel support in multi-machine config. #230

Merged
merged 1 commit into from Apr 14, 2016

Conversation

jtreminio
Copy link
Contributor

Closes #159

Speeds up creating two new servers by appx. 100%.

@seth-reeser
Copy link
Member

Thank you for the pull request @jtreminio! What testing have you done around this?

@jtreminio
Copy link
Contributor Author

Unfortunately I'm not knowledgeable enough to create automated tests for
this language.

However parallelism is a core feature implemented in vagrant core since a
few versions ago.

Not sure if testing a core feature is within the scope of this plugin.
On Feb 6, 2016 10:49 AM, "Seth Reeser" notifications@github.com wrote:

Thank you for the pull request @jtreminio https://github.com/jtreminio!
What testing have you done around this?


Reply to this email directly or view it on GitHub
#230 (comment)
.

@pbrazdil
Copy link

I can confirm it's working as expected.

Test case does not make sense as it's core feature.

@seth-reeser seth-reeser merged commit bfb6f76 into devopsgroup-io:master Apr 14, 2016
@jtreminio jtreminio deleted the parallel-support branch April 14, 2016 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants