Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MELDThermal Coordinate Derivatives #163

Closed
sean-engelstad opened this issue Mar 31, 2023 · 2 comments
Closed

MELDThermal Coordinate Derivatives #163

sean-engelstad opened this issue Mar 31, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request testing new test suite features

Comments

@sean-engelstad
Copy link
Contributor

sean-engelstad commented Mar 31, 2023

  • Add coordinate derivatives for aero and structural disciplines to the MeldThermal class
  • Should just involve differentiating the weight matrix involved in the T and Q residuals w.r.t. xa0 and xs0
  • Will have to add to MeldThermal.cpp, TransferScheme.pxd, TransferScheme.pyx, and the body.py file
  • Discovered these features are missing because the aerothermal coordinate derivatives in my coordinate derivatives unittest for the TacsOnewayDriver were off by 100%. Aerothermoelastic was very off too
@sean-engelstad sean-engelstad self-assigned this Mar 31, 2023
@sean-engelstad sean-engelstad added enhancement New feature or request testing new test suite features labels Mar 31, 2023
@sean-engelstad
Copy link
Contributor Author

Apparently we didn't use to need them. However, now with number of aero nodes and struct nodes changing the weight matrix for thermal transfer will change when integrated with ESP/CAPS shape optimization. Therefore we need these coordinate derivatives now

@sean-engelstad
Copy link
Contributor Author

We fix the aerodynamic + structural coordinates for the thermal transfer scheme. This may cause remeshing shape derivatives to be less accurate. However, that is why we need structural mesh morphing. Closing this issue for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing new test suite features
Projects
None yet
Development

No branches or pull requests

1 participant