Fix the install rule in libctru’s the Makefile #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remove the '/' between $(DESTDIR) should already have a trailing '/', otherwise a blank value will break relative paths. |
|
Here, fixed. |
The current way was depending on tar and bzip2 to first create a binary package then extract it in the directory pointed by DEVKITPRO. This commit makes the install rule only copy the relevant files, and handle correctly the standard DESTDIR variable, so packagers can use it to make their own packages.
|
Any news on this issue? |
Merged
|
The changes in this pull request collide with the devkitARM build process. Unfortunately it cannot be accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way was depending on tar and bzip2 to first create a binary
package then extract it in the directory pointed by DEVKITPRO.
This commit makes the install rule only copy the relevant files, and
handle correctly the standard DESTDIR variable, so packagers can use it
to make their own packages.