Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSON lib configurable #57

Closed
abitdodgy opened this issue Jun 5, 2019 · 3 comments
Closed

Make JSON lib configurable #57

abitdodgy opened this issue Jun 5, 2019 · 3 comments

Comments

@abitdodgy
Copy link
Contributor

abitdodgy commented Jun 5, 2019

New versions of Phoenix and Ecto are using Jason as the default JSON library. Any interest in making the JSON library configurable? Something like...

config :cloudex, :json_library, Jason

Then, whenever we are calling it, we can do something like...

@json_library Application.get_evn(:cloudex, :json_library)

def foo do
  @json_library.decode!(...)
end
@smeevil
Copy link
Owner

smeevil commented Jun 6, 2019

Sounds like a good plan 👍 otherwise making Jason the default would be fine as well.

@abitdodgy
Copy link
Contributor Author

@smeevil see #58

@abitdodgy
Copy link
Contributor Author

Merged in #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants