Image regex is case sensitive

[walter]

If I'm not mistaken https://github.com/smeevil/cloudex/blob/master/lib/cloudex.ex#L6 will not match JPG, GIF, etc.

I'm also curious what the reasoning is for checking that the file has an extension. I'm going to have workaround this in when using Phoenix upload mechanism where the temp file doesn't have an extension.

[smeevil]

Thank you for bringing the case insensitivity to the light. I've updated it to be case insensitive now.

Checking the file extension was more to make sure we are uploading something useful to Cloudinary, this should be replaced with a mime type check to make it less fickle and to remove the dependency of an extension. @manukall maybe you have some input as well about this ?

[manukall]

to be honest i'm directly using the functions in Cloudex.CloudinaryApi.Live, mainly because of this check. imho it could completely go and maybe be offered as an opt-in helper function, like image_list |> Cloudex.filter_image_urls |> Cloudex.upload.

[walter]

I'm also of the opinion that the check should be an optional helper. Feels like Phoenix uploads are a common case. The submitted filename is available in the Plug.Upload struct and that is would be the easier thing to check against rather than path.

Alternatively Cloudex.upload could provide an option to skip the check.

[smeevil]

I've updated the hex and removed both the file and url extension checks.
Thank you all for your input on this 👍

[walter]

Thanks @smeevil!