Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve accessibility of reset button #341

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

paulschreiber
Copy link
Contributor

Improve the accessibility of the reset button:

  • make it a button
  • add an aria label

@smeijer smeijer force-pushed the develop branch 3 times, most recently from 7618154 to 6453ded Compare October 3, 2022 19:26
@smeijer
Copy link
Owner

smeijer commented Oct 3, 2022

I agree this needs to get fixed, but this will require some additional styling as well. Can you add those, so the button stays visually the same?

image

@smeijer
Copy link
Owner

smeijer commented Oct 3, 2022

Aaaand fixed 🙂 Thanks so much for the contribution.

@smeijer smeijer changed the title Improve accessibility of reset button feat: improve accessibility of reset button Oct 3, 2022
@smeijer smeijer merged commit 912de5f into smeijer:develop Oct 3, 2022
@smeijer
Copy link
Owner

smeijer commented Oct 3, 2022

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants