fix: ensure remote errors in LocationIQ Provider are handled #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle 404 errors from locationIQ
cleanup typescript
smeijer
changed the title
|
Thank you! |
|
@all-contributors please add @t1m0thy for code |
|
I've put up a pull request to add @t1m0thy! 🎉 |
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Location IQ throws a 404 error when it is unable to locate any match. such as when typing "san Angl" and there are no places that begin with that string. To repair, the parse method checks for the
response.data.errorin the response, returns an empty string if it has an error, and otherwise, hands back up to the parent class.I am new to this library (and not a typescript expert), so while I believe this works, if there is a better way to handle errors, happy to learn!