Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving away from setup tools #88

Closed
kpcyrd opened this issue Aug 21, 2023 · 4 comments
Closed

Moving away from setup tools #88

kpcyrd opened this issue Aug 21, 2023 · 4 comments

Comments

@kpcyrd
Copy link

kpcyrd commented Aug 21, 2023

hello!

This project currently depends on setuptools-rust, from what I understand setuptools is deprecated and the project should instead use something like maturin to build a wheel. :)

Is there a way to build a wheel with the current tools? (I'm by far not an expert on this)

Thank you!

@daggaz
Copy link
Collaborator

daggaz commented Aug 21, 2023

@smheidrich is the expert here, but I think we're tied to setuptools-rust because maturin does support building optional extensions:
PyO3/maturin#1081

@smheidrich
Copy link
Owner

Exactly what @daggaz said. Maturin is a million times more convenient but without optional extension support we can't use it.

@kpcyrd I also haven't heard anything about setuptools or setuptools-rust getting deprecated, could you share a link if there were any announcements or plans of moving in that direction?

@kpcyrd
Copy link
Author

kpcyrd commented Aug 21, 2023

It seems I've confused setuptools and setup.py: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

I also noticed python -m build works as expected and setup.py doesn't have to be used, so nothing to do here. 🙃

Thanks and sorry for bothering!

@kpcyrd kpcyrd closed this as completed Aug 21, 2023
@smheidrich
Copy link
Owner

smheidrich commented Aug 21, 2023

I'll get rid of setup.py in favor of setup.cfg or pyproject.toml soon given that PyO3/setuptools-rust#208 has recently been implemented 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants